refactor(oxfmt): Split overridable format options #18019
Merged
+398
−394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the format configuration structure by splitting overridable format options into a separate FormatConfig struct. This improves the organization and separation of concerns between per-file formatting options and global configuration like ignore patterns.
Changes:
- Introduced new
FormatConfigstruct containing all formatting options that can be overridden per-file - Restructured
Oxfmtrcto use flattenedFormatConfigand keep onlyignore_patternsat the top level - Modified
OxfmtOptionsto containFormatOptionsdirectly instead of having them separated - Updated
into_options()to return(OxfmtOptions, Vec<String>)instead of(FormatOptions, OxfmtOptions) - Converted
populate_prettier_configfrom instance method to standalone function
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxfmt/src/core/oxfmtrc.rs | Introduces FormatConfig struct, refactors Oxfmtrc and OxfmtOptions, updates into_options() signature and converts populate_prettier_config to standalone function, updates all tests |
| apps/oxfmt/src/core/config.rs | Updates to use new OxfmtOptions structure, imports populate_prettier_config as function, updates field access to use format_config, contains a critical bug with incorrect variable name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leaysgur
force-pushed
the
01-15-refactor_oxfmt_split_overridable_format_options
branch
from
93f88e0 to
fe82698
Compare
This was referenced Jan 15, 2026
Dunqing
approved these changes
Jan 15, 2026
Contributor
Merge activity
|
Preparation for #17585. - Extract format related parts from `Oxfmtrc` to reuse as `overrides`. - Since using `serde(flatten)`, no user facing changes - Refine `OxfmtOptions` - Before: `Oxfmtrc` - `oxc_formatter::FormatOptions` - After: `Oxfmtrc` - `ignorePatterns`(not overridable)
graphite-app
bot
force-pushed
the
01-15-refactor_oxfmt_split_overridable_format_options
branch
from
fe82698 to
de72378
Compare
graphite-app
bot
deleted the
01-15-refactor_oxfmt_split_overridable_format_options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #17585.
Oxfmtrcto reuse asoverrides.serde(flatten), no user facing changesOxfmtOptionsOxfmtrc-oxc_formatter::FormatOptionsOxfmtrc-ignorePatterns(not overridable)