Skip to content

Bump sigs.k8s.io/controller-runtime from v0.20.4 to v0.22.4 #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ChenYi015 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bump sigs.k8s.io/controller-runtime from v0.20.4 to v0.22.4 #2754

ChenYi015 wants to merge 5 commits into from

Conversation

@ChenYi015
Copy link
Member

@ChenYi015 ChenYi015 commented Nov 25, 2025 •
edited
Loading

Purpose of this PR

Proposed changes:

  • Bump k8s.io/* from v0.32.5 to v0.34.1
  • Bump sigs.k8s.io/controller-runtime from v0.20.4 to v0.22.4
  • Update CRD manifests
  • Update generated code
  • Fix unit tests
  • Skip golangci-lint check on ctrl.Request.Requeue and corev1.Endpoints

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@ChenYi015
Bump sigs.k8s.io/controller-runtime from v0.20.4 to v0.22.4
acb0cdf 
- Update k8s.io/* packages to v0.34.1
- Update sigs.k8s.io/controller-runtime to v0.22.4
- Fix unit tests

Signed-off-by: Yi Chen <[email protected]>
@google-oss-prow google-oss-prow bot requested a review from ImpSy November 25, 2025 04:07
@google-oss-prow
Copy link
Contributor

google-oss-prow bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chenyi015. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from nabuskey November 25, 2025 04:07
@ChenYi015
Update CRD manifests
a3962ef 
Signed-off-by: Yi Chen <[email protected]>
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Nov 25, 2025
@ChenYi015 ChenYi015 force-pushed the bump-controller-runtime branch from ac25cd3 to 2e3ed68 Compare November 25, 2025 09:44
@ChenYi015 ChenYi015 force-pushed the bump-controller-runtime branch from 2e3ed68 to 3217c53 Compare November 25, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ImpSy ImpSy Awaiting requested review from ImpSy

@nabuskey nabuskey Awaiting requested review from nabuskey

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ChenYi015