Skip to content

Conversation

@hbelmiro
Copy link
Contributor

Description of your changes:

Added support for release-<major>.<minor> branches (e.g., release-1.11) across all CI workflows, following the Kubeflow Pipelines branching convention.

Changes

  • Documentation: Added "Branching Strategy" section to CONTRIBUTING.md
  • Workflows: Added release-* to branch triggers in all 9 workflow files
  • Scripts: Changed detect.py default from origin/main to origin/HEAD for generic local usage

Branch Convention

Branch Base Image Tag
main :main
release-1.11 :v1.11.0

Checklist:

Pre-Submission Checklist

Additional Checklist Items for New or Updated Components/Pipelines

  • metadata.yaml includes fresh lastVerified timestamp
  • All required files
    are present and complete
  • OWNERS file lists appropriate maintainers
  • README provides clear documentation with usage examples
  • Component follows snake_case naming convention
  • No security vulnerabilities in dependencies
  • Containerfile included if using a custom base image

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hbelmiro. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro hbelmiro marked this pull request as ready for review January 10, 2026 14:53
Copilot AI review requested due to automatic review settings January 10, 2026 14:53
@hbelmiro
Copy link
Contributor Author

/hold for a root approval too.

cc @mprahl @HumairAK

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for release branches (e.g., release-1.11) across the CI/CD infrastructure, aligning with Kubeflow Pipelines' branching conventions. The changes enable CI workflows to run on both the main branch and release branches, and update documentation to guide contributors on the branching strategy.

Changes:

  • Added comprehensive branching strategy documentation to CONTRIBUTING.md with examples
  • Updated all 9 GitHub workflow files to trigger on both main and release-* branches
  • Changed detect.py script default reference from origin/main to origin/HEAD for generic local usage

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/CONTRIBUTING.md Adds new "Branching Strategy" section documenting release branch naming, purpose, and base image tag conventions
.github/workflows/yaml-lint.yml Adds release-* to pull_request branches and normalizes quoting to single quotes
.github/workflows/validate-metadata-schema.yml Adds release-* branch trigger for pull_request events
.github/workflows/scripts-tests.yml Adds release-* branch triggers for both push and pull_request events with single quote normalization
.github/workflows/readme-check.yml Adds release-* branch trigger for pull_request events
.github/workflows/python-lint.yml Adds release-* to pull_request branches and normalizes quoting to single quotes
.github/workflows/markdown-lint.yml Adds release-* to pull_request branches and normalizes quoting to single quotes
.github/workflows/component-pipeline-tests.yml Adds release-* branch triggers for both push and pull_request events (uses double quotes)
.github/workflows/build-packages.yml Adds release-* branch triggers for both push and pull_request events with single quote normalization
.github/workflows/base-image-check.yml Adds release-* branch triggers for both push and pull_request events with single quote normalization
.github/scripts/detect_changed_assets/detect.py Changes default base-ref from origin/main to origin/HEAD for generic local usage
.github/scripts/detect_changed_assets/README.md Updates documentation to reflect origin/HEAD as the default base reference
.github/actions/detect-changed-assets/README.md Updates input documentation table to clarify dynamic default for base-ref in PR context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 10, 2026 15:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 134 to 137
python3 .github/scripts/detect_changed_assets/detect.py --base-ref origin/HEAD --head-ref HEAD
# With pattern filter
python3 .github/scripts/detect_changed_assets/detect.py --base-ref origin/main --filter '\.py$'
python3 .github/scripts/detect_changed_assets/detect.py --base-ref origin/HEAD --filter '\.py$'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be using uv here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should. Fixed.

Comment on lines 194 to 197
| Branch | Purpose | Base Image Tag |
|---------------------------|--------------------------------------------|-----------------------|
| `main` | Active development | `:main` |
| `release-<major>.<minor>` | Release maintenance (e.g., `release-1.11`) | `:v<major>.<minor>.0` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's be explicit that z-stream releases could be possible (not always x.y.0)

Suggested change
| Branch | Purpose | Base Image Tag |
|---------------------------|--------------------------------------------|-----------------------|
| `main` | Active development | `:main` |
| `release-<major>.<minor>` | Release maintenance (e.g., `release-1.11`) | `:v<major>.<minor>.0` |
| Branch | Purpose | Base Image Tag |
|---------------------------|--------------------------------------------|---------------------------------|
| `main` | Active development | `:main` |
| `release-<major>.<minor>` | Release maintenance (e.g., `release-1.11`) | `:v<major>.<minor>.<z-stream>` |

Also, it may be outside the scope of this PR but if not perhaps adding a quick section about z-stream releases here, their contents, and what triggers them may be useful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

…nstead of `python3` in scripts and documentation

Signed-off-by: Helber Belmiro <[email protected]>
…e guidelines in CONTRIBUTING.md

Signed-off-by: Helber Belmiro <[email protected]>
Copilot AI review requested due to automatic review settings January 13, 2026 19:07
@hbelmiro hbelmiro requested a review from gmfrasca January 13, 2026 19:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 13, 2026 21:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants