Skip to content

Conversation

@liavweiss
Copy link

@liavweiss liavweiss commented Dec 10, 2025

Related: #780 (part 1,2,6)

Updated dependencies

golang.org/x/net → v0.47.0 (addresses CVE-2022-27664/CVE-2025-22870/CVE-2025-22872 and other high/critical CVEs in the Go networking stack)
golang.org/x/crypto → v0.45.0 (keeps crypto primitives up to date with the net bump)
golang.org/x/sys → v0.38.0, golang.org/x/term → v0.37.0, golang.org/x/text → v0.31.0 (transitive upgrades brought in by the x/net bump)

Validation performed

  • go mod tidy: passed
  • make manager (go fmt + go vet + go build): passed
  • Controller workflows (nb_controller_unit_test, integration, multi-arch) passed
  • notebooks-v1 deployment + notebooks creation(for testing) - passed
  • Checks for braking changes - passed

Trivy checks:

Before change: number of open CVEs - 64
After change: number of open CVEs - 46

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Dec 10, 2025
@google-oss-prow google-oss-prow bot added the area/controller area - related to controller components label Dec 10, 2025
@google-oss-prow google-oss-prow bot requested a review from kimwnasptd December 10, 2025 10:41
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added area/v1 area - version - kubeflow notebooks v1 size/S labels Dec 10, 2025
@andyatmiami
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @liavweiss for this contribution.

i independently confirmed the verification checks performed by the PR author are reproducible and valid.

furthermore, in analyzing the changes introduced across the significant version bumps of upgraded dependencies, I am comfortable with them being safe for our usage.

  • x/crypto: critical functional changes revolve around usage of an SSH server which doesn't apply to our usage..

  • x/net: critical functional changes revolve around usage of html parsing and/orHTTP/2 server which doesn't apply to our usage

  • x/sys | x/term | x/text : less controversial changes that reasonably verified by the application continuing to build

ℹ️ similar testing of same versions was also performed on #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 lgtm ok-to-test size/S

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants